From d781d857452588fff238fda15f6663744d9eac0e Mon Sep 17 00:00:00 2001
From: CodePanter <codepanter@gmail.com>
Date: Thu, 7 Apr 2016 20:56:28 +0200
Subject: [PATCH] Fixed the problem with pixels missing in the message and
 prevented general exceptions from crashing the server.

---
 client.py |  4 +---
 vloed.py  | 47 +++++++++++++++++++++++++----------------------
 2 files changed, 26 insertions(+), 25 deletions(-)

diff --git a/client.py b/client.py
index 96d8627..9a4dbbb 100755
--- a/client.py
+++ b/client.py
@@ -14,7 +14,6 @@ import random
 import time
 
 class MaxSizeList(list):
-  maxsize = 0
 
   def __init__(self, maxcount=100):
     self.maxsize = maxcount
@@ -25,7 +24,6 @@ class MaxSizeList(list):
     if self.__len__() == self.maxsize:
       raise IndexError('max size reached')
 
-
 def RGBPixel(x, y, r, g, b, a=None): # pylint: disable=C0103
   """Generates the packed data for a pixel"""
   if a:
@@ -55,7 +53,7 @@ def RandomFill(width=640, height=480):
       message.append(pixel)
     except IndexError:
       yield ''.join(message)
-      message[:] = []
+      message[2:] = []
       message.append(pixel)
   yield ''.join(message)
 
diff --git a/vloed.py b/vloed.py
index 4209857..b232cc3 100755
--- a/vloed.py
+++ b/vloed.py
@@ -35,7 +35,7 @@ class Canvas(object):
     self.screen = None
     self.udp_ip = UDP_IP
     self.udp_port = UDP_PORT
-    self.canvas()    
+    self.canvas()
     self.set_title()
     self.queue = queue
     self.limit = 140
@@ -86,31 +86,34 @@ class Canvas(object):
       # indicat that nothing was done, and w can skip flipping the screen
       return False
     #access the pixel array and lock it
-    self.pixels = pygame.surfarray.pixels2d(self.screen) 
+    self.pixels = pygame.surfarray.pixels2d(self.screen)
     returntime = time.time() + (1.0 / self.fps)
-    # while we have stuff in the queue, and its not our next time to draw a 
+    # while we have stuff in the queue, and its not our next time to draw a
     # frame, lets process packets from the queue
     while time.time() < returntime and not self.queue.empty():
-      data = self.queue.get()
-      preamble = struct.unpack_from("<?", data)[0]
-      protocol = struct.unpack_from("<B", data, 1)[0]
-      packetformat = ("<2H4B" if preamble else "<2H3B")
-      pixellength = (8 #xx,yy,r,g,b,a 
-                     if preamble else 
-                     7 #xx,yy,r,g,b
-                     )
-      pixelcount = (len(data)-1) / pixellength
-      if self.debug:
-        print '%d pixels received, protocol V %d ' % (
-            min(pixelcount, self.limit), protocol)
-      for i in xrange(0, pixelcount):
-        pixel = struct.unpack_from(
-            packetformat,
-            data,
-            self.pixeloffset + (i*pixellength))
+      try:
+        data = self.queue.get()
+        preamble = struct.unpack_from("<?", data)[0]
+        protocol = struct.unpack_from("<B", data, 1)[0]
+        packetformat = ("<2H4B" if preamble else "<2H3B")
+        pixellength = (8 #xx,yy,r,g,b,a
+                       if preamble else
+                       7 #xx,yy,r,g,b
+                       )
+        pixelcount = (len(data)-1) / pixellength
         if self.debug:
-          print pixel
-        self.Pixel(*pixel)
+          print '%d pixels received, protocol V %d ' % (
+              min(pixelcount, self.limit), protocol)
+        for i in xrange(0, pixelcount):
+          pixel = struct.unpack_from(
+              packetformat,
+              data,
+              self.pixeloffset + (i*pixellength))
+          if self.debug:
+            print pixel
+          self.Pixel(*pixel)
+      except Exception as e:    #All exceptions will be printed, but won't result in a crash.
+        print e
     # indicate that we have been drawing stuff
     return True